Merge pull request #418 from catalyst/fix-502-forcelogin-tests

Fix outage step test by forcing login default to off

classes/local/outagelib.php

@@ -267,6 +267,10 @@ class outagelib {
         // single-quotes (and double for the sake of it) are present otherwise it would break the code.
         $allowedips = addslashes($allowedips);
 
+        // Escape the access key before substitution into the PHP literal to prevent
+        // code injection via a maliciously crafted access key value.
+        $accesskey = addslashes((string)$accesskey);
+
         $cookiesecure = is_moodle_cookie_secure();
 
         // Since Moodle 4.3 cookiehttponly is default to true and this CFG is not set.

tests/base_testcase.php

@@ -95,6 +95,9 @@ abstract class base_testcase extends \advanced_testcase {
 
         parent::setUp();
         $this->resetAfterTest(true);
+
+        // These tests rely on force login being disabled, but Moodle 5.2 enables it by default (MDL-87523).
+        set_config('forcelogin', 0);
     }
 
     /**

version.php

@@ -28,8 +28,8 @@
 defined('MOODLE_INTERNAL') || die();
 
 $plugin->component = "auth_outage";
-$plugin->version = 2026011304;          // The current plugin version (Date: YYYYMMDDXX).
-$plugin->release = 2026011304;          // Human-readable release information.
+$plugin->version = 2026011306;          // The current plugin version (Date: YYYYMMDDXX).
+$plugin->release = 2026011305;          // Human-readable release information.
 $plugin->requires = 2025100600;         // Moodle 5.1.
 $plugin->maturity = MATURITY_STABLE;    // Suitable for PRODUCTION environments!
 $plugin->supported = [501, 501];        // A range of branch numbers of supported moodle versions.