mirror/moodle-auth_outage
1
0 Fork 0
mirror of https://github.com/catalyst/moodle-auth_outage.git synced 2026-10-22 10:18:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #351 from catalyst/issue-350-MOODLE_39_STABLE-test-errors

Browse Source 
Fix #350: Do not setcookie during unit tests
This commit is contained in:
Brendan Heywood authored and GitHub committed 2024-11-28 07:32:42 +11:00
2 parents 386a623bb3 2a55769a86
commit 7f55f5d403
2 files changed
+6 -6
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

classes/local/outagelib.php
+2 -2
View File
@@ -311,8 +311,9 @@ if ((time() >= {{STARTTIME}}) && (time() < {{STOPTIME}})) {
}
// Put access key as a cookie if given. This stops the need to put it as a url param on every request.
$urlaccesskey = optional_param('accesskey', null, PARAM_TEXT);
$isphpunit = defined('PHPUNIT_TEST');
if (!empty($urlaccesskey)) {
if (!empty($urlaccesskey) && !$isphpunit) {
setcookie('auth_outage_accesskey', $urlaccesskey, time() + 86400, '/', '', {{COOKIESECURE}}, {{COOKIEHTTPONLY}});
}
@@ -322,7 +323,6 @@ if ((time() >= {{STARTTIME}}) && (time() < {{STOPTIME}})) {
$ipblocked = !remoteip_in_list('{{ALLOWEDIPS}}');
$accesskeyblocked = $useraccesskey != '{{ACCESSKEY}}';
$allowed = ({{USEACCESSKEY}} && !$accesskeyblocked) || ({{USEALLOWEDIPS}} && !$ipblocked);
$isphpunit = defined('PHPUNIT_TEST');
if (!$allowed) {
if (!$isphpunit) {
tests/local/outagelib_test.php
+4 -4
View File
@@ -323,8 +323,9 @@ if ((time() >= 123) && (time() < 456)) {
}
// Put access key as a cookie if given. This stops the need to put it as a url param on every request.
$urlaccesskey = optional_param('accesskey', null, PARAM_TEXT);
$isphpunit = defined('PHPUNIT_TEST');
if (!empty($urlaccesskey)) {
if (!empty($urlaccesskey) && !$isphpunit) {
setcookie('auth_outage_accesskey', $urlaccesskey, time() + 86400, '/', '', true, false);
}
@@ -336,7 +337,6 @@ a.b.c.d
e.e.e.e/20');
$accesskeyblocked = $useraccesskey != '12345';
$allowed = (true && !$accesskeyblocked) || (true && !$ipblocked);
$isphpunit = defined('PHPUNIT_TEST');
if (!$allowed) {
if (!$isphpunit) {
@@ -404,8 +404,9 @@ if ((time() >= 123) && (time() < 456)) {
}
// Put access key as a cookie if given. This stops the need to put it as a url param on every request.
$urlaccesskey = optional_param('accesskey', null, PARAM_TEXT);
$isphpunit = defined('PHPUNIT_TEST');
if (!empty($urlaccesskey)) {
if (!empty($urlaccesskey) && !$isphpunit) {
setcookie('auth_outage_accesskey', $urlaccesskey, time() + 86400, '/', '', true, false);
}
@@ -415,7 +416,6 @@ if ((time() >= 123) && (time() < 456)) {
$ipblocked = !remoteip_in_list('127.0.0.1');
$accesskeyblocked = $useraccesskey != '5678';
$allowed = (true && !$accesskeyblocked) || (true && !$ipblocked);
$isphpunit = defined('PHPUNIT_TEST');
if (!$allowed) {
if (!$isphpunit) {